encode and decode paths in Util::Pathname#2545
Draft
xworld21 wants to merge 2 commits intobrucemiller:masterfrom
Draft
encode and decode paths in Util::Pathname#2545xworld21 wants to merge 2 commits intobrucemiller:masterfrom
xworld21 wants to merge 2 commits intobrucemiller:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2413 and various straightforward file name encoding issues that can be addressed directly in Util::Pathname. It is stacked on top of #2544 because it also uses Encode::Locale, and of course it is easier to test if I can pass non-ASCII characters to latexmlpost.
This is not yet a complete fix for all encoding issues, such as #2336, because I still need to replace every call to
open,readdir,-r,-f, and so on with suitable calls topathname_openand similar. That's going to be a lot more invasive.